Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lab 4,5 #203

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

lab 4,5 #203

wants to merge 2 commits into from

Conversation

MagicGiant
Copy link

No description provided.

Copy link
Owner

@somov7 somov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 за delete
-1 за кодировку
-2 за битые файлы после манипуляций
8

@@ -0,0 +1,25 @@
#include <stdio.h>
#include "str.h"
char *get_10_2 (int data, int size, int iterator, char *arr)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// codestyle
Не надо писать имплементацию функций в .h файле

Copy link
Owner

@somov7 somov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.5

5.c
void check_color()
{
int color = 0;
fseek(fin, 59, SEEK_SET);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// codestyle
59 - magic number

5.c
}
if (strcmp(argv[i], "--output")==0)
{
path=malloc(strlen(argv[i+1])+1);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// logical
Утечка памяти
-0.5

5.c
}
if (strcmp(argv[i], "--max_iter")==0)
{
n=0;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// codestyle
лучше вынести в функцию

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants